FIX: Add closing quote to match condition#2864
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewfeickert
force-pushed
the
fix/close-match
branch
from
1da0dbd to
a135d99
Compare
| If the build can be executed with one line, you may put this line in the | ||
| `script` entry of the `build` section of the recipe file with: | ||
| `script: "{{ PYTHON }} -m pip install . -vv"`. | ||
| `script: "{{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation"`. |
There was a problem hiding this comment.
I thought this was set automatically? So there is no need to do it manually.
There was a problem hiding this comment.
@xhochy I believe this is correct for rattler-build, but I do not know if this is true for conda-build. I had suggested removing these flags before in conda/grayskull#582, but @ocefpaf has requested that they remain in (c.f. conda/grayskull#582 (comment)).
Regardless, the documentation should be consistent across the conda-forge docs. So once choice should be selected and then used everywhere.
There was a problem hiding this comment.
This fails only on multiple outputs and conda-build as far as I know. That is where my recommendation comes from. If we ditch v0, and rattler-build multiple outputs does suffer from that. I agree, don't include it b/c it is unnecessary. Regarding consistency... I'll abstain from that bike shed ;-p
There was a problem hiding this comment.
This fails only on multiple outputs and conda-build as far as I know.
...
I agree, don't include it b/c it is unnecessary.
If there is agreement that for v1 recipes this is redundant and should be avoided, should we keep the --no-deps --no-build-isolation flags in below for the v0 example?
* Add missing '"' to close the match condition. * Add '--no-deps --no-build-isolation' flags to the v0 example Python build commands to match the current recommendations. - c.f. https://conda-forge.org/docs/maintainer/example_recipes/pure-python/ * As setuptools is not the only build system that exists after PEP 517/518 use the term "build system" and then provide setuptools as an example.
matthewfeickert
force-pushed
the
fix/close-match
branch
from
a135d99 to
f909551
Compare
| ```recipe | ||
| build: | ||
| script: "{{ PYTHON }} -m pip install . -vv" | ||
| script: "{{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation" |
There was a problem hiding this comment.
As this is the v0 recipe instructions, keep the flags given #2864 (comment)
3 participants
"to close the match condition.--no-deps --no-build-isolationflags to the v0 example Python build commands to match the current recommendations.PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfileThis PR addresses multiple things on a single docs page. If it is preferable to split this between multiple PRs I can split out the doc improvements (
--no-deps --no-build-isolationand build systems) from the syntax fix.